Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak available handling #30

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Tweak available handling #30

merged 1 commit into from
Apr 1, 2024

Conversation

dmulcahey
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.83%. Comparing base (325a772) to head (da5542c).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
+ Coverage   93.63%   93.83%   +0.19%     
==========================================
  Files          61       61              
  Lines        9409     9421      +12     
==========================================
+ Hits         8810     8840      +30     
+ Misses        599      581      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey merged commit a6d4727 into dev Apr 1, 2024
6 checks passed
@dmulcahey dmulcahey deleted the dm/tweak-available-handling branch April 1, 2024 23:25
async def test_device_counter_sensors(
zha_gateway: Gateway, caplog: pytest.LogCaptureFixture
) -> None:
async def test_device_counter_sensors(zha_gateway: Gateway) -> None:
"""Test quirks defined sensor."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test quirks defined sensor."""
"""Test coordinator counter sensor."""

elec_measurement_zha_dev: Device, # pylint: disable=redefined-outer-name
caplog: pytest.LogCaptureFixture,
) -> None:
"""Test quirks defined sensor."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test quirks defined sensor."""
"""Test polling is skipped for unavailable device."""


assert entity.state["state"] is None

# simulate counter increment on application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# simulate counter increment on application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants